Skip to content

fix: revert "fix: don't pipe plugin output more than once at the time (#6765)" #6769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

fix: revert "fix: don't pipe plugin output more than once at the time (#6765)" #6769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions packages/build/src/log/stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,25 +47,13 @@ const pushBuildCommandOutput = function (output: string, logsArray: string[]) {
logsArray.push(output)
}

const pipedPluginProcesses = new WeakMap<ChildProcess, ReturnType<typeof pipePluginOutput>>()

// Start plugin step output
export const pipePluginOutput = function (
childProcess: ChildProcess,
logs: Logs,
standardStreams: StandardStreams,
): LogsListeners | undefined {
if (pipedPluginProcesses.has(childProcess)) {
return pipedPluginProcesses.get(childProcess)
export const pipePluginOutput = function (childProcess: ChildProcess, logs: Logs, standardStreams: StandardStreams) {
if (!logsAreBuffered(logs)) {
return streamOutput(childProcess, standardStreams)
}

const listeners = !logsAreBuffered(logs)
? streamOutput(childProcess, standardStreams)
: pushOutputToLogs(childProcess, logs, standardStreams.outputFlusher)

pipedPluginProcesses.set(childProcess, listeners)

return listeners
return pushOutputToLogs(childProcess, logs, standardStreams.outputFlusher)
}

// Stop streaming/buffering plugin step output
Expand All @@ -83,12 +71,10 @@ export const unpipePluginOutput = async function (
}

unpushOutputToLogs(childProcess, listeners.stdoutListener, listeners.stderrListener)

pipedPluginProcesses.delete(childProcess)
}

// Usually, we stream stdout/stderr because it is more efficient
const streamOutput = function (childProcess: ChildProcess, standardStreams: StandardStreams): undefined {
const streamOutput = function (childProcess: ChildProcess, standardStreams: StandardStreams) {
childProcess.stdout?.pipe(standardStreams.stdout)
childProcess.stderr?.pipe(standardStreams.stderr)
}
Expand Down
Loading