feat: add a --prodIfUnlocked flag #1988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets you publish to production if it's unlocked in the Netlfify dashboard and create drafts otherwise. closes #1392 The oclif/command lib doesn't let us create a `--prod=auto` flag that's also a boolean flag so it's separate. I think it's clearer anyway.
erezrokah
added
the
type: feature
erezrokah
suggested changes
Mar 15, 2021
Contributor
There was a problem hiding this comment.
Thanks @kasbah for closing your own issue :)
For some reason I can't push changes to the PR, can you make sure to allow edits from maintainers?
To get the tests to pass you need to sync the docs as described here https://github.com/netlify/cli/blob/master/CONTRIBUTING.md#pull-requests.
Also, can you please use camelCase for the flag to be consistent with other flags?
kasbah
changed the title
Contributor
Author
|
Hey, thanks for reviewing. I've made the suggested changes. Not sure why you can't push to my branch or how best to enable it. Let me know if you still need access. |
erezrokah
approved these changes
Mar 15, 2021
This was referenced Mar 15, 2021
Merged
Closed
Closed
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you publish to production if it's unlocked in the Netlfify dashboard and create drafts otherwise.
closes #1392
The oclif/command lib doesn't let us create a
--prod=autoflag that's also a boolean flag so it's separate. I think it's clearer anyway.