Skip to content

Conversation

@kathmbeck
Copy link
Contributor

@kathmbeck kathmbeck commented Sep 4, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Provides initial AI gateway support for local dev. Tested locally with bootstrap changes.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

📊 Benchmark results

Comparing with 961abee

  • Dependency count: 1,078 ⬆️ 0.46% increase vs. 961abee
  • Package size: 298 MB ⬆️ 0.12% increase vs. 961abee
  • Number of ts-expect-error directives: 381 (no change)

@kathmbeck kathmbeck changed the title feat: Support AI gateway feat: support ai gateway Sep 4, 2025
@kathmbeck kathmbeck marked this pull request as ready for review September 17, 2025 19:10
@kathmbeck kathmbeck requested a review from a team as a code owner September 17, 2025 19:10
@@ -0,0 +1,110 @@
import { TestContext } from 'vitest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pointing out that the pattern of having a util file for a specific chunk of tests, away from the test file itself, is not a pattern I've seen in this repo. Same goes for the usage of a function (createAIGatewayCheckFunction) to generate the functions to be tested, which feels like yet another abstraction on top of the site builder that may make tests a bit harder to follow.

Not an issue necessarily, and definitely not a blocker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're saying, I pulled this out because I had about ~200 lines of duplication. I could really go either way though -- happy to inline back if you think the consistency is more beneficial.

Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kathmbeck kathmbeck merged commit efb5a3f into main Sep 19, 2025
47 checks passed
@kathmbeck kathmbeck deleted the support-ai-gateway branch September 19, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants