-
Notifications
You must be signed in to change notification settings - Fork 434
feat: support ai gateway #7609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ai gateway #7609
Conversation
…nto support-ai-gateway
…nto support-ai-gateway
tests/integration/commands/functions-serve/functions-serve.test.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,110 @@ | |||
| import { TestContext } from 'vitest' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointing out that the pattern of having a util file for a specific chunk of tests, away from the test file itself, is not a pattern I've seen in this repo. Same goes for the usage of a function (createAIGatewayCheckFunction) to generate the functions to be tested, which feels like yet another abstraction on top of the site builder that may make tests a bit harder to follow.
Not an issue necessarily, and definitely not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you're saying, I pulled this out because I had about ~200 lines of duplication. I could really go either way though -- happy to inline back if you think the consistency is more beneficial.
eduardoboucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🎉 Thanks for submitting a pull request! 🎉
Summary
Provides initial AI gateway support for local dev. Tested locally with bootstrap changes.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)