Skip to content

Conversation

khendrikse
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

This should help unblock the tests that were failing all over the place 🙏

  1. Fixed the hanging test issue - The original problem was that callCli spawns a subprocess that can't
    inherit inquirer mocks, causing tests to hang waiting for user input
  2. Converted tests to use execa directly - This gives us proper control over subprocess stdin/stdout
  3. Used handleQuestions for interactive tests - This allows us to programmatically provide input to prompts
  4. Ensured all required parameters are provided - Added --branch flags where needed to avoid unexpected
    prompts
  5. Implemented the todo test - Created a proper test for interactive mode when no prompt is provided

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested a review from a team as a code owner October 17, 2025 12:06
Copy link

📊 Benchmark results

Comparing with 627040e

  • Dependency count: 1,031 (no change)
  • Package size: 284 MB (no change)
  • Number of ts-expect-error directives: 380 (no change)

Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@khendrikse khendrikse merged commit 1c684f9 into main Oct 17, 2025
71 of 74 checks passed
@khendrikse khendrikse deleted the chore/fix-agents-create-tests branch October 17, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants