Skip to content

fix: free the underlying HTMLRewriter if the TransformStream has been cancelled #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: free the underlying HTMLRewriter if the TransformStream has been cancelled #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/html_rewriter_wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class HTMLRewriter {
response = new Response(response.body, response);
}

let rewriter: RawHTMLRewriter;
let rewriter: RawHTMLRewriter | undefined;
const transformStream = new TransformStream<Uint8Array, Uint8Array>({
start: (controller) => {
// Create a rewriter instance for this transformation that writes its
Expand All @@ -39,10 +39,21 @@ export class HTMLRewriter {
rewriter.on(selector, handlers);
}
},
transform: (chunk) => rewriter.write(chunk),
transform: (chunk) => rewriter?.write(chunk),
// deno-lint-ignore require-await
async cancel() {
if (rewriter) {
rewriter.end();
rewriter.free();
rewriter = undefined;
}
},
flush: () => {
rewriter.end();
rewriter.free();
if (rewriter) {
rewriter.end();
rewriter.free();
rewriter = undefined;
}
},
});

Expand Down
Loading