Skip to content
This repository was archived by the owner on Oct 10, 2022. It is now read-only.

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 11, 2021

Part of https://github.com/netlify/bitballoon/issues/9616

This decreases the maximum number of retries from 10 to 5.
Retries are helpful to improve reliability of client requests. However, in case of total API outage, retrying makes clients wait for longer to receive the error response, and it unnecessarily increases API load.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label May 11, 2021
@ehmicky ehmicky requested a review from erezrokah May 11, 2021 16:20
@ehmicky ehmicky self-assigned this May 11, 2021
@erezrokah
Copy link
Contributor

Same as other PRs, this should be fix:

@ehmicky ehmicky changed the title chore: decrease the number of API retries fix: decrease the number of API retries May 11, 2021
@github-actions github-actions bot added the type: bug code to address defects in shipped code label May 11, 2021
@ehmicky ehmicky merged commit e85dbe4 into main May 11, 2021
@ehmicky ehmicky deleted the fix/max-retry branch May 11, 2021 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants