Fix panic in ntoml when checking paths #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheffner
approved these changes
May 13, 2020
Contributor
mheffner
left a comment
mheffner
left a comment
There was a problem hiding this comment.
Looks good, yeah would be great to provide more error handling/notification in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildbot can panic with an error like this: humio link
We're attempting to stat a filepath in this code, but only checking for one error case: that the file wasn't found.
I'm guessing we're hitting permission denied because the user provided a path outside the working directory (https://golang.org/pkg/os/#IsPermission)
I think it would be nice to warn if we're ignoring some path because of an error, but we don't have access to a logger here and returning early with the error would cause us to fail builds that could have proceeded with some other path.
Fixes https://github.com/netlify/buildbot/issues/742