Skip to content

Fix err check in ntoml path checker #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Fix err check in ntoml path checker #123

merged 1 commit into from
May 13, 2020

Conversation

@vbrown608
Copy link
Contributor

@vbrown608 vbrown608 commented May 13, 2020 •
edited
Loading

Made a small mistake in my last PR 🙃

We want to check that the error is nil when we stat the file. Added a test to catch this.

@vbrown608 vbrown608 requested a review from a team May 13, 2020 16:53
@vbrown608 vbrown608 added the type: bug code to address defects in shipped code label May 13, 2020
@vbrown608 vbrown608 requested review from Benaiah and mheffner May 13, 2020 17:09
@vbrown608 vbrown608 merged commit d55e552 into master May 13, 2020
@vbrown608 vbrown608 deleted the fix-ntoml-error-check branch May 13, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benaiah Benaiah Awaiting requested review from Benaiah

@mheffner mheffner Awaiting requested review from mheffner

1 more reviewer

@emilyzhang emilyzhang emilyzhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: bug code to address defects in shipped code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vbrown608 @emilyzhang