Skip to content

provide default config for logging #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2020
Merged

provide default config for logging #183

merged 2 commits into from
Dec 4, 2020

Conversation

rybit
Copy link
Member

@rybit rybit commented Sep 29, 2020

I was trying to use this for a silly script, I didn't configure any logging parameters and then this started to panic. This should prevent that

@rybit rybit marked this pull request as ready for review September 29, 2020 21:43
@rybit rybit requested a review from a team September 29, 2020 21:43
@rybit rybit added the type: chore work needed to keep the product and development running smoothly label Sep 29, 2020
emilyzhang
emilyzhang previously approved these changes Sep 29, 2020
View reviewed changes
@rybit
Copy link
Member Author

rybit commented Sep 29, 2020

ok so I was working on this a bit more - but I was struggling with Viper, essentially it was doing the right mapping, but it wouldn't unmarshal properly. This gets rid of that dependency.

@rybit
Copy link
Member Author

rybit commented Sep 29, 2020

This should be transparent:

  • there are no services that use yaml to my knowledge
  • the json parsing should work exactly the same
  • no changes for env files

@rybit rybit requested a review from emilyzhang December 4, 2020 23:21
@rybit rybit merged commit 4b21cdc into master Dec 4, 2020
@rybit rybit deleted the logging-config branch December 4, 2020 23:39
@mraerino mraerino mentioned this pull request Dec 16, 2020
Merged
mraerino added a commit that referenced this pull request Dec 18, 2020
@mraerino
Revert "provide default config for logging (#183)"
75c2c4e 
This reverts commit 4b21cdc.
@mraerino mraerino mentioned this pull request Dec 18, 2020
Merged
mraerino added a commit that referenced this pull request Jan 4, 2021
@mraerino
Revert config loading refactors (#204)
8ff9829 
* Revert "Fix usage of struct tags for config (#203)"

This reverts commit 8d1e696.

* Revert "provide default config for logging (#183)"

This reverts commit 4b21cdc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@emilyzhang emilyzhang emilyzhang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rybit @emilyzhang