Skip to content

Conversation

mraerino
Copy link
Contributor

Reverts these PRs:

I was getting this error at proxy startup when updating this lib:

Failed to parse configuration: failed to map data: 11 error(s) decoding:\n\n* 'launch_darkly.request_timeout' expected type 'time.Duration', got unconvertible type 'string'\n* 'log_conf.quote_empty_fields' expected type 'bool', got unconvertible type 'string'\n* 'origin_limits.backoff_ratio' expected type 'float64', got unconvertible type 'string'\n* 'origin_limits.enabled' expected type 'bool', got unconvertible type 'string'\n* 'origin_limits.increment' expected type 'int', got unconvertible type 'string'\n* 'origin_limits.minimum' expected type 'int', got unconvertible type 'string'\n* 'origin_limits.slowstart' expected type 'int', got unconvertible type 'string'\n* 'origin_limits.timeout' expected type 'time.Duration', got unconvertible type 'string'\n* 'timeouts.function.response_header' expected type 'time.Duration', got unconvertible type 'string'\n* 'timeouts.origin.response_header' expected type 'time.Duration', got unconvertible type 'string'\n* 'timeouts.proxy.response_header' expected type 'time.Duration', got unconvertible type 'string'

we might be able to avoid this when switching to json or yaml struct tags, but this would mean a lot of changes in different services and i don't think the effort is justified right now.

cc @rybit

@mraerino mraerino added the type: bug code to address defects in shipped code label Dec 18, 2020
@mraerino mraerino self-assigned this Dec 18, 2020
@mraerino mraerino requested a review from a team as a code owner December 18, 2020 13:17
@mraerino mraerino requested a review from rybit December 18, 2020 13:29
@mraerino mraerino merged commit 8ff9829 into master Jan 4, 2021
@mraerino mraerino deleted the chore/revert-config-loading branch January 4, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants