Skip to content

Fix usage of struct tags for config #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2020
Merged

Fix usage of struct tags for config #203

merged 3 commits into from
Dec 16, 2020

Conversation

mraerino
Copy link
Contributor

@mraerino mraerino commented Dec 16, 2020 •
edited
Loading

#183 introduced a breaking change that meant the struct tag mapstructure could no longer be used to map config keys.

since this is used in various services we need to restore this behaviour.

@mraerino mraerino added the type: bug code to address defects in shipped code label Dec 16, 2020
@mraerino mraerino requested review from mheffner and rybit December 16, 2020 14:50
@mraerino mraerino requested a review from a team as a code owner December 16, 2020 14:50
@mraerino mraerino self-assigned this Dec 16, 2020
mheffner
mheffner reviewed Dec 16, 2020
View reviewed changes
nconf/configuration.go Outdated
return fmt.Errorf("failed to read config: %w", err)
}

if err := mapstructure.Decode(&config, &input); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be just input?

This comment was marked as outdated.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yup. changed.

@mraerino mraerino requested a review from mheffner December 16, 2020 15:48
mheffner
mheffner approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@mheffner mheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mraerino mraerino merged commit 8d1e696 into master Dec 16, 2020
@mraerino mraerino deleted the fix/config-deserialize branch December 16, 2020 20:55
mraerino added a commit that referenced this pull request Dec 18, 2020
@mraerino
Revert "Fix usage of struct tags for config (#203)"
446d33b 
This reverts commit 8d1e696.
@mraerino mraerino mentioned this pull request Dec 18, 2020
Merged
mraerino added a commit that referenced this pull request Jan 4, 2021
@mraerino
Revert config loading refactors (#204)
8ff9829 
* Revert "Fix usage of struct tags for config (#203)"

This reverts commit 8d1e696.

* Revert "provide default config for logging (#183)"

This reverts commit 4b21cdc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rybit rybit Awaiting requested review from rybit

1 more reviewer

@mheffner mheffner mheffner approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mraerino mraerino

Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraerino @mheffner