service => graphQLField #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwwoelfel
reviewed
Jun 30, 2022
src/auth.ts
Outdated
| const parts = x.split(':'); | ||
|
|
||
| if (parts.length !== 2) { | ||
| throw new Error('TODO parts'); |
There was a problem hiding this comment.
Will this error be surfaced to the user?
src/auth.ts
Outdated
| return service.service; | ||
| } | ||
| } else { | ||
| return 'service identified by field ' + service.graphQLField; |
There was a problem hiding this comment.
Let's just return service.graphQLField here or sentence cased service.graphQLField if you want to write a sentenceCase function.
The end user that's looking at this may not be aware that there is any graphql thing anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.