Skip to content

Conversation

@danez
Copy link
Contributor

@danez danez commented Jul 13, 2022

Summary

Fix the tests, by removing node 18 from the workflow. Webpack 4 does not support node 17 and up. So if we want to support node 17 and up we would need to update webpack.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code
    🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
    fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@danez danez added the type: chore work needed to keep the product and development running smoothly label Jul 13, 2022
webpack 4 is and will not be compatible to node 17 and up by default
So netlify-lambda does not support node 17 or up
@danez danez changed the title chore: increase test timeout chore: fix tests Jul 13, 2022
@danez danez requested review from a team, Skn0tt, eduardoboucas, jackiewmacharia and khendrikse and removed request for a team July 14, 2022 08:50
@danez danez merged commit 036759c into main Jul 14, 2022
@danez danez deleted the testtimeout branch July 14, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants