Skip to content
This repository was archived by the owner on May 2, 2022. It is now read-only.

Add .js to the bundle filename #68

Closed
wants to merge 1 commit into from
Closed

Add .js to the bundle filename #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ async function publishBundle(bundle, handlers, outputDir, isLocal, apiToken) {

/** @type {import("./upload").BundleInfo} */
const bundleInfo = {
sha: shasum.digest("hex"),
sha: `${shasum.digest("hex")}.js`,
Copy link
Contributor

@calavera calavera Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change this to not be named sha, since it has an extension?

Copy link
Contributor Author

@ehmicky ehmicky Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it. How would you like it to be named?
I am assuming this would require changes in both Netlify Dev and the manifest loader though?

handlers,
// needs to have length of the byte representation, not the string length
content_length: buf.length,
Expand Down