fix: preserve original path after middleware rewrite #2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pieh
force-pushed
the
fix/preserve-original-path-after-middleware-rewrite
branch
3 times, most recently
from
8e86daa to
9de97eb
Compare
pieh
force-pushed
the
fix/preserve-original-path-after-middleware-rewrite
branch
from
9de97eb to
2b5b6f8
Compare
pieh
commented
Jun 27, 2023
Comment on lines
+42
to
+45
| if (!parsedUrl && typeof req?.headers?.['x-middleware-rewrite'] === 'string') { | ||
| parsedUrl = parse(req.headers['x-middleware-rewrite'], true) | ||
| } | ||
|
|
There was a problem hiding this comment.
Next does same parsing in https://github.com/vercel/next.js/blob/7dfa56c7141ae2556af0d7fd837e0af686d8fa55/packages/next/src/server/base-server.ts#L662-L665 and later on does a lot of checking on it and potentially messing with it.
Passing parsedUrl along the request handler route allows some control
MarcL
reviewed
Jun 27, 2023
kodiakhq
bot
deleted the
fix/preserve-original-path-after-middleware-rewrite
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This looks to address issue with
localenot being set correctly (or at least not in the same way asnext build+next startbehaves) when there is rewrite happening in middleware which in turn cause weirdness with client-side routing.Documentation
Tests
Added a test case to cypress tests
Relevant links (GitHub issues, etc.) or a picture of cute animal