feat: add retry count field #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mraerino
approved these changes
Jul 12, 2022
Contributor
mraerino
left a comment
mraerino
left a comment
There was a problem hiding this comment.
does the JS client also need this?
Member
Author
Yes 💯! I'll work on that next. |
biruwon
reviewed
Jul 13, 2022
biruwon
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clients retry an operation, we would like to propagate the retry number to the API, so that it can adjust its behaviour accordingly.
To do this, this PR adds a
X-Nf-Retry-Countheader, which is empty on the first attempt, and contains1on the first retry, and so on.Currently, we're adding the field to the
uploadDeployFunctiononly.Part of https://github.com/netlify/pod-compute/issues/140.