Skip to content

Conversation

@pvorozhe
Copy link
Contributor

In the CLI and API docs, remove instances of [Beta] from netlify env commands and API reference.

Fixes https://github.com/netlify/pillar-workflow/issues/919 (1/2)

@pvorozhe pvorozhe requested a review from a team as a code owner October 28, 2022 15:48
@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for open-api ready!

Name Link
🔨 Latest commit 15b6315
🔍 Latest deploy log https://app.netlify.com/sites/open-api/deploys/63618a36fae99200072336c2
😎 Deploy Preview https://deploy-preview-404--open-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 28, 2022
akahn
akahn previously approved these changes Oct 28, 2022
swagger.yml Outdated
[Beta] Returns all environment variables for an account or site. An
Returns all environment variables for an account or site. An
account corresponds to a team in the Netlify UI. To use this endpoint,
opt in to the beta environment variable experience using the Netlify UI.
Copy link
Contributor

@codebyuma codebyuma Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the next line that says ...opt in to the beta environment variable experience... for each of these endpoints.

I have conflicting thoughts:

a) We could just remove the last line entirely as this new experience is the new default. Similar to how the docs are written as "new experience-first" (similar to how we say "mobile-first"). This is helpful for new teams as they won't need to stop and wonder if they have to migrate, they can just use the API right away.

b) But, we may still find a lot of current teams checking these reference docs and they may have existing sites that need to be migrated first. So, we could replace it with something like: If you encounter issues with this endpoint, your site might be using the classic environment variables experience. Migrate your site using the Netlify UI.

The second option seems safest and it's what we use in the Docs - it's just long...

I should know this but can't remember - does the API return anything helpful if you try to use these endpoints on a site that hasn't been migrated?

Copy link
Contributor

@codebyuma codebyuma Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to think of a shorter variation that only existing users need to care about:

To use this endpoint, your site must no longer be using the classic environment experience. Migrate now with the Netlify UI ??

This one still might make new teams stop and wonder if they can use it though... 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second one sounds reasonable to me - i think there is only so much we can do with so little text to describe this feature rollout

Copy link
Contributor

@codebyuma codebyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy update looks good to me - glad that the link works! Thanks for making these updates

@pvorozhe pvorozhe merged commit f802843 into master Nov 2, 2022
@pvorozhe pvorozhe deleted the pvorozhe/sm-remove-beta-language branch November 2, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants