feat: add functions_config parameter to deploy #420
Conversation
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: feature
khendrikse
force-pushed
the
feat-204/add-functions-config-to-buildbot-deploy
branch
from
c1d4eec to
92c921d
Compare
go/porcelain/deploy.go
Outdated
| "site_id": options.SiteID, | ||
| "deploy_files": len(options.files.Sums), | ||
| "scheduled_functions": len(schedules), | ||
| "functions_config": functionsConfig, |
There was a problem hiding this comment.
I don't think you want to log the entire map here, because it's not something that renders very well in the structured logs. You can see that for other properties we're printing strings or numbers. I would consider revisiting this and figuring out what would be useful to log here.
There was a problem hiding this comment.
Makes total sense now that you say it, I removed it, as I think right now it is not useful to log something. Maybe when we get the autogenerated information in the future, that would be interesting to log. To know how many of the functions were autogenerated functions for example :)
|
Confirmed that this works by trying it out in a draft pr of buildbot! ✨ |
khendrikse
deleted the
feat-204/add-functions-config-to-buildbot-deploy
branch
Some work to support https://github.com/netlify/pod-compute/issues/192 in buildbot :)