fix(workflow-ui): use packageId for package paths when set
#1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugins ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
benedfit
commented
Jan 16, 2023
|
|
||
| mkdir -p site/$PACKAGE | ||
| cp package/workflow-ui.json site/$PACKAGE/workflow-ui.json | ||
| PACKAGE_ID=$(cat package/workflow-ui.json | jq -r ".packageId // .package") |
Contributor
Author
There was a problem hiding this comment.
When the workflow-ui.json contains packageId use that as the destination for the files rather than the package name. So /surfaces/site-settings/@netlify/feature-package-pilot would become /surfaces/site-settings/feature-pilot
sean-roberts
approved these changes
Jan 17, 2023
Contributor
sean-roberts
left a comment
sean-roberts
left a comment
There was a problem hiding this comment.
LGTM. This decision for package id was from a previous conversation with the integrations team to better support the mobility of a package to change owners (npm names/scopes) without breaking our systems references what the content is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing the Netlify plugins directory!
Are you adding a plugin or updating one?
Have you completed the following?
Test plan
Please add a link to a successful public deploy log using the stated version of the plugin. Include any other context reviewers might need for testing.