Skip to content

Conversation

@rfreling
Copy link
Contributor

For submission/review! 🔍 ⚡

Thanks for contributing the Netlify plugins directory!

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plan
Please add a link to a successful public deploy log using the stated version of the plugin. Include any other context reviewers might need for testing.

@ehmicky
Copy link
Contributor

ehmicky commented Jan 31, 2022

Hi @rfreling,

Thanks a lot for this Build plugin, this is awesome!

I have added a couple of comments as repository issues, please let me know what you think.

But it looks great! 🎉

Small note: the commit message must be prefixed with feat: to follow Conventional commit guidelines.

@ehmicky ehmicky changed the title Plugin Submission: CommandBar + Netlify feat: plugin Submission: CommandBar + Netlify Jan 31, 2022
@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 31, 2022
For submission/review! 🔍  ⚡
@netlify-bot
Copy link
Collaborator

@rfreling
Copy link
Contributor Author

rfreling commented Feb 9, 2022

Thanks a bunch @ehmicky ! And sorry for the slow reply.

The issues you suggested made a lot of sense, and I think we addressed all of them [LINK]

Let us know if there's anything else that we should work on / update!

@ehmicky
Copy link
Contributor

ehmicky commented Feb 9, 2022

Nice, this is good to go! 🎉
One last thing: you need to publish a new version on npm and update the version in this PR. The current one 0.0.2 is the previous one. Thanks!

@rfreling
Copy link
Contributor Author

rfreling commented Feb 9, 2022

Awesome, thank you! Just updated and published

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ehmicky ehmicky merged commit e3011c8 into netlify:main Feb 9, 2022
@rfreling rfreling deleted the patch-1 branch February 9, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature code contributing to the implementation of a feature and/or user facing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants