-
Notifications
You must be signed in to change notification settings - Fork 67
feat: add New Relic plugin #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
site/plugins.json
Outdated
| }, | ||
| { | ||
| "author": "aaronbassett", | ||
| "description": "The New Relic Netlify plugin automatically notifies New Relic of Netlify build events and installs the New Relic browser agent.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle suggestion: Maybe shorten description to "Automatically notifies New Relic of Netlify build events and installs the New Relic browser agent."
This prevents the description from wrapping to a new line, leaving the word "agent" on its own
site/plugins.json
Outdated
| "author": "aaronbassett", | ||
| "description": "The New Relic Netlify plugin automatically notifies New Relic of Netlify build events and installs the New Relic browser agent.", | ||
| "name": "New Relic", | ||
| "package": "@newrelic/newrelic-netlify-plugin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
We usually follow a naming convention documented here which would lead to a package name more along the lines of either @newrelic/netlify-plugin or @newrelic/netlify-plugin-some-suffix.
Would this be possible to rename the npm package name? If that's too much of a problem though, the current name works too 👍
|
@aaronbassett This plugin is going to be so useful to both Netlify and New Relic users! From a code quality standpoint, this is both one of the largest (code size-wise) and most well written plugins we've reviewed in a couple of years. Amazing job! It looks all good, except for a few comments on the Apart from this, this looks ready to ship! 🚀 🚀 🚀 |
|
Hey, @MelanieCrissey @ehmicky thank you for your kind words and feedback! I've requested a new scoped npm package be created with the requested name change and I'll publish the plugin there once completed. I'll also make the changes to the description and commit messages when I update the plugin name in this PR |
ehmicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉 🎉
|
Thanks again for all your help @MelanieCrissey and @ehmicky! |
Thanks for contributing the Netlify plugins directory!
Are you adding a plugin or updating one?
Have you completed the following?
Test plan
https://gist.github.com/aaronbassett/f19ec43e6da0e9c69c00c932c4ae0d32