Skip to content

Conversation

@aaronbassett
Copy link
Contributor

Thanks for contributing the Netlify plugins directory!

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plan

https://gist.github.com/aaronbassett/f19ec43e6da0e9c69c00c932c4ae0d32

CleanShot 2022-02-03 at 14 12 51@2x

@ehmicky ehmicky self-requested a review February 3, 2022 19:28
},
{
"author": "aaronbassett",
"description": "The New Relic Netlify plugin automatically notifies New Relic of Netlify build events and installs the New Relic browser agent.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle suggestion: Maybe shorten description to "Automatically notifies New Relic of Netlify build events and installs the New Relic browser agent."

This prevents the description from wrapping to a new line, leaving the word "agent" on its own

"author": "aaronbassett",
"description": "The New Relic Netlify plugin automatically notifies New Relic of Netlify build events and installs the New Relic browser agent.",
"name": "New Relic",
"package": "@newrelic/newrelic-netlify-plugin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!
We usually follow a naming convention documented here which would lead to a package name more along the lines of either @newrelic/netlify-plugin or @newrelic/netlify-plugin-some-suffix.
Would this be possible to rename the npm package name? If that's too much of a problem though, the current name works too 👍

@ehmicky ehmicky changed the title Add New Relic plugin feat: add New Relic plugin Feb 4, 2022
@ehmicky
Copy link
Contributor

ehmicky commented Feb 4, 2022

@aaronbassett This plugin is going to be so useful to both Netlify and New Relic users!

From a code quality standpoint, this is both one of the largest (code size-wise) and most well written plugins we've reviewed in a couple of years. Amazing job!

It looks all good, except for a few comments on the name and description. Also, we use conventional commits to automate releases, so the git commit message must be prefixed with feat: and be followed by a lowercase letter.

Apart from this, this looks ready to ship! 🚀 🚀 🚀

@aaronbassett
Copy link
Contributor Author

Hey, @MelanieCrissey @ehmicky thank you for your kind words and feedback!

I've requested a new scoped npm package be created with the requested name change and I'll publish the plugin there once completed. I'll also make the changes to the description and commit messages when I update the plugin name in this PR

@netlify-bot
Copy link
Collaborator

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@ehmicky ehmicky merged commit cd090a1 into netlify:main Feb 7, 2022
@aaronbassett
Copy link
Contributor Author

Thanks again for all your help @MelanieCrissey and @ehmicky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants