Skip to content

Conversation

@daviddarnes
Copy link
Contributor

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plan
Please add a link to a successful public deploy log using the stated version of the plugin. Include any other context reviewers might need for testing. https://app.netlify.com/sites/netlify-plugin-ghost-markdown-demo/deploys/630490577d2b184655b30fa6

Ps. Has the local development workflow improved for Build Plugins? I currently have an additional repo which is connected to a Netlify site just to test my plugin locally. Ideally I'd have a test / demo directory in my Build Plugin repo which I can test with and demonstrate the plugin. Can anyone give me any pointers? Thanks!

As the title describes.

Ps. Has the local development workflow improved for Build Plugins? I currently have an additional repo which is connected to a Netlify site just to test my plugin locally. Ideally I'd have a test / demo directory in my Build Plugin repo which I can test with and demonstrate the plugin. Can anyone give me any pointers? Thanks!
@netlify-bot
Copy link
Collaborator

@ericapisani
Copy link
Contributor

Hi @daviddarnes ,

Thanks for submitting a pull request!

Regarding your question about the local development workflow - I think you might be interested in taking a peek (if you haven't already) at Netlify's Next.js Runtime repo for an example that includes demo sites that are used for testing and demonstrating various use cases (the default one can be found here).

Let me know if that's what you had in mind or if you have any follow up questions about that (though if we have a more extended back and forth, happy to move the conversation into an issue on your plugin's repository)

@ericapisani ericapisani added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 8, 2022
@ericapisani ericapisani changed the title Update netlify-plugin-ghost-markdown to v3.1.0 feat: update netlify-plugin-ghost-markdown to v3.1.0 Sep 8, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@kodiakhq kodiakhq bot merged commit 9d8dc66 into netlify:main Sep 8, 2022
@daviddarnes
Copy link
Contributor Author

Thanks very much @ericapisani! I’ll take a look at that repo. I think the dev workflow has improved since I first made it so hopefully I can tighten things up into a single repo and single site demo.

Ps. Thanks for merging the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: feature code contributing to the implementation of a feature and/or user facing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants