fix: set proper peer dependencies #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
force-pushed
the
fix/set-proper-peer-deps-for-tanstack-start
branch
from
8427c11 to
b06ead4
Compare
eduardoboucas
approved these changes
Sep 24, 2025
| import { Test } from '~/start' | ||
|
|
||
| export const Route = createFileRoute('/')({ | ||
| // server: { |
Contributor
Author
There was a problem hiding this comment.
I have no idea what's the plan :) The fixture changes were copied straight from https://github.com/TanStack/router/blob/065722ab2949b1a6b8493dc288d37dfd0e19c3ff/examples/react/start-basic/src/routes/index.tsx
I wanted to keep the fixture in sync with that example in tanstack repo to make it easy to keep updating, so I was not removing those comments while pasting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #455 (comment)
This also updates fixture by syncing changes done to https://github.com/TanStack/router/tree/main/examples/react/start-basic