Skip to content

Conversation

@serhalp
Copy link
Member

@serhalp serhalp commented Nov 14, 2025

Add Node 24 to the CI test matrix and update engines.node in @netlify/vite-plugin-tanstack-start to support Node 24.


Linear Issue: FRB-2049

Open in Cursor Open in Web

Co-authored-by: philippe.serhal <philippe.serhal@gmail.com>
@cursor
Copy link

cursor bot commented Nov 14, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Copy link
Member Author

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent just one tweak

@cursor
Copy link

cursor bot commented Nov 14, 2025

Updated the workflow so the default Node matrix now explicitly targets ['24'] while still keeping the existing Ubuntu 20.6.1 include entry, and tightened the npm@10 condition accordingly. Let me know if you’d like any other adjustments.


Open in Cursor Open in Web

Learn more about Cursor Agents

@serhalp serhalp changed the title Update ci for node 24 feat: support node.js 24 Nov 14, 2025
cursoragent and others added 2 commits November 14, 2025 14:46
Co-authored-by: philippe.serhal <philippe.serhal@gmail.com>
Co-authored-by: philippe.serhal <philippe.serhal@gmail.com>
Copy link
Member Author

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhalp serhalp marked this pull request as ready for review November 14, 2025 17:23
@serhalp serhalp requested a review from a team as a code owner November 14, 2025 17:23
@serhalp serhalp enabled auto-merge (squash) November 14, 2025 17:31
@serhalp serhalp merged commit 5d361ec into main Nov 14, 2025
20 of 21 checks passed
@serhalp serhalp deleted the cursor/FRB-2049-update-ci-for-node-24-07fd branch November 14, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants