fix: handle HTTP/2 requests with pseudo-headers #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP/2 requests are required to have a specific set of request and response "pseudo-headers": https://www.rfc-editor.org/rfc/rfc9113.html#name-request-pseudo-header-field. When converting a Node.js `IncomingMessage` to a Web `Request`, we must ignore these pseudo-headers because `IncomingMessage.prototype.headers` *does* contain them, but newer versions of Node.js will throw on `new Request()` if given any such header.
serhalp
commented
Nov 14, 2025
| }) | ||
| await dev.start() | ||
|
|
||
| const nodeReq = new IncomingMessage(new Socket()) |
Member
Author
There was a problem hiding this comment.
I wish we could keep this high level and just "create an HTTP/2 request" but there doesn't appear to be a good way to do that.
eduardoboucas
approved these changes
Nov 14, 2025
eduardoboucas
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 requests are required to have a specific set of request and response "pseudo-headers": https://www.rfc-editor.org/rfc/rfc9113.html#name-request-pseudo-header-field.
When converting a Node.js
IncomingMessageto a WebRequest, we must ignore these pseudo-headers becauseIncomingMessage.prototype.headersdoes contain them, but newer versions of Node.js will throw onnew Request()if given any such header.Fixes #528.