template doesn't run on fresh clone

[Klrfl]

This template doesn't run on fresh clone. I have another app which is currently experiencing difficulties deploying to Netlify as well.

What I did

# 1. clone template
# 2. install dependencies
# 3. run netlify serve

git clone git@github.com:netlify/react-router-template.git
cd react-router-template
npm i 
netlify serve

Actual behavior

An error message comes up:

{"errorMessage":"Cannot find module '/home/munthe/web-dev/rr-netlify/.netlify/functions-serve/.unzipped/handler/node_modules/@react-router/node/dist/index.mjs' imported from /home/munthe/web-dev/rr-netlify/.netlify/functions-serve/.unzipped/handler/.netlify/functions-internal/handler/index.mjs","errorType":"Error","trace":["Error: Cannot find module '/home/munthe/web-dev/rr-netlify/.netlify/functions-serve/.unzipped/handler/node_modules/@react-router/node/dist/index.mjs' imported from /home/munthe/web-dev/rr-netlify/.netlify/functions-serve/.unzipped/handler/.netlify/functions-internal/handler/index.mjs"," at finalizeResolution (node:internal/modules/esm/resolve:275:11)"," at moduleResolve (node:internal/modules/esm/resolve:860:10)"," at defaultResolve (node:internal/modules/esm/resolve:984:11)"," at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:780:12)"," at ModuleLoader.#cachedDefaultResolve (node:internal/modules/esm/loader:704:25)"," at ModuleLoader.resolve (node:internal/modules/esm/loader:687:38)"," at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:305:38)"," at ModuleJob._link (node:internal/modules/esm/module_job:175:49)"]}

Expected

It should serve the app like normal.

I think this is an issue with Netlify's Vite plugin, but I don't know enough to point to any direction

[bcbrian]

Ultimately this is an issue with how Node does module resolution, starting with 20.19 and Node.22.

This is the change you need to get it to work:
bcbrian@35f6939

Here is a pr as well.
#11

[serhalp]

Hi there. This was actually a regression introduced to our build system for about 24 hours and also introduced to Netlify CLI 23.1.0 and fixed a few days later in 23.1.3. This should be fully fixed. Are you still experiencing this with the latest Netlify CLI or via the Netlify platform's build system?

[bcbrian]

Yes I have been experiencing it today in both environments. The error you referenced is similar but not the same. But the fix might be in the same place.

I have been debugging this 2 weeks or so. If I am missing something let me know. I don't think you guys "broke" it.

From what I can tell we don't grab the mjs and js files. Node is now pretty strict. so it looks for mjs explicitly and wont soft resolve to a js file. in node 20.18 and less it does not care.

Here is the same issue from June https://answers.netlify.com/t/netlify-vite-plugin-react-router-couldnt-complete-build-process-with-react-router-v7/152575

Sharing a screen shot from my vid in the pr that I recorded this morning. That is in the PR.

This works with node < 20.19 it does not with node >= 20.19|22.x

I used npx netlify-cli serve which resolved to netlify-cli@23.1.4. I did this in the last 5 min. It works with node 20.18.3 but not 20.19 or 22.x.

[markuslewin]

I think this is due to @netlify/zip-it-and-ship-it running an old version of @vercel/nft when bundling the functions. The old version doesn't try to match against the module-sync key in the package.json#exports of @react-router/node. That behavior was introduced in @vercel/nft@0.30.0.

I can get it to work by switching versions in node_modules:

npm i -D netlify-cli @vercel/nft@0.30.0
rm -r node_modules/netlify-cli/node_modules/@vercel/nft/
cp -r node_modules/@vercel/nft/ node_modules/netlify-cli/node_modules/@vercel/
npx netlify serve

[serhalp]

🤔 but we had fixed this issue by pinning to @vercel/nft@0.29.4 because it was caused by 0.30.0 (on node 22). It can't also be the other way around 🤯.

[markuslewin]

Yeah, sorry, I was so happy I got it to work with netlify serve that I missed it broke the deploy...

[markuslewin]

Ahaaa, so Node ships with some experimental features enabled, AWS disables those features, and Netlify disables those features for the bundler by pinning the version of nft. So the problem is actually that those experimental features aren't disabled when netlify serve runs.

The following does indeed work for me:

gh repo clone netlify/react-router-template
cd react-router-template
npm i -D netlify-cli
NODE_OPTIONS="--no-experimental-require-module --no-experimental-detect-module" npx netlify serve

And I can actually deploy that build output with npx netlify deploy --prod --no-build as well. 🙂

---

To be clear, I only encountered the issue when running netlify serve on my machine. I only tried it with Node v22.16.0.

[serhalp]

Hi folks! Thank you so much for that deep investigation @markuslewin! It was really helpful to get to the bottom of this. You were spot on.

I've released a fix to netlify-cli: https://github.com/netlify/cli/releases/tag/v23.9.4.

This reproduces the issue:

npx -y netlify@23.9.3 serve

while this works as expected:

npx -y netlify@23.9.4 serve

🎉