Skip to content

Conversation

@eranra
Copy link
Collaborator

@eranra eranra commented Feb 24, 2022

No description provided.

@eranra eranra self-assigned this Feb 24, 2022
@eranra eranra force-pushed the improve_version branch 2 times, most recently from 77b6f4c to 6be3869 Compare February 24, 2022 10:47
@eranra eranra linked an issue Feb 24, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #101 (e1184ef) into main (59852cf) will decrease coverage by 0.49%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   54.80%   54.30%   -0.50%     
==========================================
  Files          37       37              
  Lines        2332     2333       +1     
==========================================
- Hits         1278     1267      -11     
- Misses        981      992      +11     
- Partials       73       74       +1     
Flag Coverage Δ
unittests 54.30% <0.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/flowlogs-pipeline/main.go 0.00% <0.00%> (ø)
pkg/pipeline/utils/exit.go 52.17% <0.00%> (-47.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59852cf...e1184ef. Read the comment docs.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eranra eranra merged commit 553f43f into netobserv:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align version to RH versioning scheme

4 participants