Skip to content

Conversation

@eranra
Copy link
Collaborator

@eranra eranra commented Feb 24, 2022

No description provided.

@eranra eranra self-assigned this Feb 24, 2022
@eranra eranra force-pushed the flowlogs2metrics_into_flowlogs-piplines#1 branch from 7920ead to 63055d0 Compare February 24, 2022 12:30
@codecov-commenter
Copy link

Codecov Report

Merging #102 (7920ead) into main (84dbf1a) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

❗ Current head 7920ead differs from pull request most recent head 63055d0. Consider uploading reports for the commit 63055d0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   54.80%   54.63%   -0.18%     
==========================================
  Files          37       37              
  Lines        2332     2332              
==========================================
- Hits         1278     1274       -4     
- Misses        981      984       +3     
- Partials       73       74       +1     
Flag Coverage Δ
unittests 54.63% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/apitodoc/main.go 100.00% <ø> (ø)
cmd/flowlogs-pipeline/main.go 0.00% <ø> (ø)
pkg/confgen/confgen.go 46.87% <ø> (ø)
pkg/confgen/config.go 42.85% <ø> (ø)
pkg/confgen/dedup.go 90.32% <ø> (ø)
pkg/confgen/doc.go 0.00% <0.00%> (ø)
pkg/confgen/encode.go 36.36% <ø> (ø)
pkg/confgen/extract.go 50.00% <ø> (ø)
pkg/confgen/flowlogs2metrics_config.go 0.00% <0.00%> (ø)
pkg/confgen/transform.go 46.66% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84dbf1a...63055d0. Read the comment docs.

@eranra eranra force-pushed the flowlogs2metrics_into_flowlogs-piplines#1 branch from 63055d0 to 16fd3c1 Compare February 24, 2022 13:04
@eranra eranra requested review from KalmanMeth and jotak February 24, 2022 13:05
@eranra eranra force-pushed the flowlogs2metrics_into_flowlogs-piplines#1 branch 2 times, most recently from 237dcbd to 9ebf0a9 Compare February 24, 2022 13:24
@eranra eranra linked an issue Feb 24, 2022 that may be closed by this pull request
@eranra eranra force-pushed the flowlogs2metrics_into_flowlogs-piplines#1 branch from 9ebf0a9 to be404e4 Compare February 24, 2022 15:04
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't guarantee I didn't miss something in the 100 files changes, but LGTM

@eranra eranra merged commit 59852cf into netobserv:main Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the push image to quay to send into flowlogs-pipeline repo

3 participants