Skip to content

Conversation

@jpinsonneau
Copy link
Collaborator

Description

Bump eBPF deps for DNS Name

Dependencies

netobserv/netobserv-ebpf-agent#820

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

To run a perfscale test, comment with: /test flp-node-density-heavy-25nodes

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 21, 2025
@jpinsonneau jpinsonneau requested a review from memodi November 21, 2025 08:46
go.mod Outdated

replace github.com/vmware/go-ipfix => github.com/jotak/go-ipfix v0.0.0-20250708115123-407c539ea101

replace github.com/netobserv/netobserv-ebpf-agent => ../netobserv-ebpf-agent
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to replace this when merged ☝️

@github-actions
Copy link

New image:
quay.io/netobserv/flowlogs-pipeline:ec3e423

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ec3e423 make set-flp-image

@memodi
Copy link
Member

memodi commented Nov 21, 2025

@jpinsonneau - are we good to run the perf test here to measure impact on FLP with the local ebpf package here?

@memodi
Copy link
Member

memodi commented Nov 21, 2025

/test flp-node-density-heavy-25nodes

@jpinsonneau
Copy link
Collaborator Author

@jpinsonneau - are we good to run the perf test here to measure impact on FLP with the local ebpf package here?

Don't we need all images at once for that ? 🤔

@memodi
Copy link
Member

memodi commented Nov 21, 2025

@jpinsonneau - are we good to run the perf test here to measure impact on FLP with the local ebpf package here?

Don't we need all images at once for that ? 🤔

In this case, I think yes, since there's a dependency with ebpf-agent. Let see what perf run come back with.

@memodi
Copy link
Member

memodi commented Nov 21, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Nov 21, 2025
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 25, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/flp-node-density-heavy-25nodes 57a697c link true /test flp-node-density-heavy-25nodes
ci/prow/qe-e2e-tests fb62aba link false /test qe-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau jpinsonneau merged commit 7262038 into netobserv:main Nov 25, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants