Skip to content

Conversation

@ronensc
Copy link
Collaborator

@ronensc ronensc commented Mar 6, 2022

Fixes #103

@ronensc ronensc requested a review from eranra March 6, 2022 15:45
@codecov-commenter
Copy link

Codecov Report

Merging #123 (5982c88) into main (e0d95f2) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   54.63%   54.62%   -0.01%     
==========================================
  Files          47       47              
  Lines        2709     2711       +2     
==========================================
+ Hits         1480     1481       +1     
- Misses       1129     1130       +1     
  Partials      100      100              
Flag Coverage Δ
unittests 54.62% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/transform/transform_network.go 61.71% <66.66%> (-0.19%) ⬇️
pkg/test/utils.go 78.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d95f2...5982c88. Read the comment docs.

@ronensc ronensc self-assigned this Mar 6, 2022
Copy link
Collaborator

@eranra eranra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ronensc ronensc merged commit 680ddb3 into netobserv:main Mar 7, 2022
@ronensc ronensc deleted the 103-bug-mice branch March 7, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: mice and elephant not working

3 participants