Skip to content

Conversation

@jotak
Copy link
Member

@jotak jotak commented Mar 8, 2022

Bumping goflow to 1.0.5 was already done previously but reverted, I assume inadvertently. So bringing it back.

Note, I have failing tests locally, but it also fails on main, not sure what's wrong:

ok  	github.com/netobserv/flowlogs-pipeline/pkg/pipeline/ingest	3.782s	coverage: 5.5% of statements in ./...
time="2022-03-08T09:06:11+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
time="2022-03-08T09:06:11+01:00" level=info msg="Got reponse 200 OK"
time="2022-03-08T09:06:11+01:00" level=info msg="Wrote 0 bytes to /tmp/location_db.bin.zip"
time="2022-03-08T09:06:11+01:00" level=info msg="os.Open err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
time="2022-03-08T09:06:11+01:00" level=info msg="ioutil.ReadFile err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
--- FAIL: Test_Transform (0.05s)
    transform_network_test.go:135: 
        	Error Trace:	transform_network_test.go:135
        	Error:      	Received unexpected error:
        	            	failed unzip zip: not a valid zip file 
        	Test:       	Test_Transform
time="2022-03-08T09:06:11+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
time="2022-03-08T09:06:11+01:00" level=info msg="Got reponse 200 OK"
time="2022-03-08T09:06:11+01:00" level=info msg="Wrote 0 bytes to /tmp/location_db.bin.zip"
time="2022-03-08T09:06:11+01:00" level=info msg="os.Open err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
time="2022-03-08T09:06:11+01:00" level=info msg="ioutil.ReadFile err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
--- FAIL: Test_TransformAddSubnetParseCIDRFailure (0.05s)
    transform_network_test.go:158: 
        	Error Trace:	transform_network_test.go:158
        	Error:      	Received unexpected error:
        	            	failed unzip zip: not a valid zip file 
        	Test:       	Test_TransformAddSubnetParseCIDRFailure
FAIL
coverage: 10.2% of statements in ./...
FAIL	github.com/netobserv/flowlogs-pipeline/pkg/pipeline/transform	0.260s
ok  	github.com/netobserv/flowlogs-pipeline/pkg/pipeline/transform/connection_tracking	4.159s	coverage: 3.4% of statements in ./...
ok  	github.com/netobserv/flowlogs-pipeline/pkg/pipeline/transform/kubernetes	0.129s	coverage: 1.1% of statements in ./...
time="2022-03-08T09:06:20+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
time="2022-03-08T09:06:20+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
time="2022-03-08T09:06:20+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
time="2022-03-08T09:06:20+01:00" level=info msg="Got reponse 200 OK"
time="2022-03-08T09:06:20+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
time="2022-03-08T09:06:20+01:00" level=info msg="Got reponse 200 OK"
time="2022-03-08T09:06:20+01:00" level=info msg="Wrote 0 bytes to /tmp/location_db.bin.zip"
time="2022-03-08T09:06:20+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
2022/03/08 09:06:20 http: superfluous response.WriteHeader call from github.com/netobserv/flowlogs-pipeline/pkg/pipeline/transform/location.Test_InitLocationDB.func12 (location_test.go:86)
time="2022-03-08T09:06:20+01:00" level=info msg="Got reponse 200 OK"
time="2022-03-08T09:06:20+01:00" level=info msg="Wrote 4 bytes to /tmp/location_db.bin.zip"
time="2022-03-08T09:06:20+01:00" level=info msg="os.Open err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
time="2022-03-08T09:06:20+01:00" level=info msg="ioutil.ReadFile err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
time="2022-03-08T09:06:20+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
2022/03/08 09:06:20 http: superfluous response.WriteHeader call from github.com/netobserv/flowlogs-pipeline/pkg/pipeline/transform/location.Test_InitLocationDB.func14 (location_test.go:103)
time="2022-03-08T09:06:20+01:00" level=info msg="Got reponse 200 OK"
time="2022-03-08T09:06:20+01:00" level=info msg="Wrote 167 bytes to /tmp/location_db.bin.zip"
time="2022-03-08T09:06:20+01:00" level=info msg="os.Open err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: permission denied"
time="2022-03-08T09:06:20+01:00" level=info msg="ioutil.ReadFile err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: permission denied"
time="2022-03-08T09:06:20+01:00" level=info msg="Downloading location DB into local file /tmp/location_db.bin "
time="2022-03-08T09:06:20+01:00" level=info msg="Got reponse 200 OK"
time="2022-03-08T09:06:20+01:00" level=info msg="Wrote 0 bytes to /tmp/location_db.bin.zip"
time="2022-03-08T09:06:20+01:00" level=info msg="os.Open err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
time="2022-03-08T09:06:20+01:00" level=info msg="ioutil.ReadFile err open /tmp/location_db.bin/IP2LOCATION-LITE-DB9.BIN: no such file or directory"
--- FAIL: Test_InitLocationDB (0.06s)
    location_test.go:116: 
        	Error Trace:	location_test.go:116
        	Error:      	Expected nil, but got: &errors.errorString{s:"failed unzip zip: not a valid zip file "}
        	Test:       	Test_InitLocationDB
time="2022-03-08T09:06:20+01:00" level=error msg=test
time="2022-03-08T09:06:20+01:00" level=error msg=test
FAIL
coverage: 4.3% of statements in ./...
FAIL	github.com/netobserv/flowlogs-pipeline/pkg/pipeline/transform/location	0.188s
ok  	github.com/netobserv/flowlogs-pipeline/pkg/pipeline/utils	0.125s	coverage: 1.4% of statements in ./...
ok  	github.com/netobserv/flowlogs-pipeline/pkg/pipeline/write	0.159s	coverage: 9.3% of statements in ./...
ok  	github.com/netobserv/flowlogs-pipeline/pkg/test	0.125s	coverage: 2.9% of statements in ./...
FAIL

@jotak jotak requested review from KalmanMeth, eranra and mariomac March 8, 2022 08:09
@eranra eranra added the bug Something isn't working label Mar 8, 2022
Copy link
Collaborator

@eranra eranra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jotak jotak merged commit 4db06d3 into netobserv:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants