Descriptive error messages on bad pipeline formation #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranra
reviewed
Mar 8, 2022
pkg/pipeline/pipeline_builder.go
Outdated
| return nil, fmt.Errorf("stage %q of type %q can't send data", | ||
| connection.Follows, srcEntry.stageType) | ||
| } | ||
| log.Debugf("connecting stages: %s --> %s", connection.Follows, connection.Name) |
Collaborator
There was a problem hiding this comment.
I think that you can move this to be info
eranra
approved these changes
Mar 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 57.14% 56.98% -0.16%
==========================================
Files 49 49
Lines 2842 2878 +36
==========================================
+ Hits 1624 1640 +16
- Misses 1103 1123 +20
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ronensc
reviewed
Mar 15, 2022
Comment on lines
+27
to
+28
| - { follows: ingest1, name: decode1 } | ||
| - { follows: decode1, name: write1 } |
Collaborator
There was a problem hiding this comment.
COOL! I didn't know that curly braces are valid in YAML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a stage is not fully connected, it returns more descriptive messages, indicating which stage is wrongly connected. E.g.: