Skip to content

Conversation

@ronensc
Copy link
Collaborator

@ronensc ronensc commented Mar 9, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #138 (51d185e) into main (e90ba0a) will increase coverage by 2.97%.
The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   54.62%   57.60%   +2.97%     
==========================================
  Files          47       51       +4     
  Lines        2711     2934     +223     
==========================================
+ Hits         1481     1690     +209     
+ Misses       1130     1128       -2     
- Partials      100      116      +16     
Flag Coverage Δ
unittests 57.60% <80.64%> (+2.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/encode/encode_prom.go 78.44% <66.66%> (-0.63%) ⬇️
pkg/pipeline/extract/aggregate/aggregate.go 91.37% <82.92%> (-5.63%) ⬇️
pkg/test/utils.go 78.66% <100.00%> (-0.29%) ⬇️
pkg/pipeline/utils/exit.go 82.60% <0.00%> (-17.40%) ⬇️
pkg/pipeline/pipeline.go 91.89% <0.00%> (-8.11%) ⬇️
pkg/pipeline/write/write_loki.go 67.04% <0.00%> (-0.19%) ⬇️
pkg/pipeline/transform/kubernetes/kubernetes.go 14.37% <0.00%> (-0.18%) ⬇️
pkg/api/enum.go 68.00% <0.00%> (ø)
pkg/config/config.go 50.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90ba0a...51d185e. Read the comment docs.

@eranra eranra linked an issue Mar 10, 2022 that may be closed by this pull request
@ronensc
Copy link
Collaborator Author

ronensc commented Mar 24, 2022

Closing in favor of #152

@ronensc ronensc closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for additinal prometheus metric types - not only gauge

2 participants