NETOBSERV-229 create pre-merge image on PR via action #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the 'ok-to-test' label to trigger the build/push
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 58.20% 58.20%
=======================================
Files 55 55
Lines 3137 3137
=======================================
Hits 1826 1826
Misses 1190 1190
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ronensc
reviewed
Apr 6, 2022
Comment on lines
+52
to
+57
| github.rest.issues.createComment({ | ||
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: 'New image: ${{ steps.push-to-quay.outputs.registry-paths }}. It will expire after two weeks.' | ||
| }) |
Collaborator
There was a problem hiding this comment.
I'm a bit confused. If this workflow is triggered by a PR, then what is the issue in context where the comment is created?
Member
Author
There was a problem hiding this comment.
in github API, a PR is apparently some special kind of issue. But the comment is actually created on the PR
ronensc
approved these changes
Apr 6, 2022
eranra
approved these changes
Apr 6, 2022
Member
Author
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the 'ok-to-test' label to trigger the build/push