-
Notifications
You must be signed in to change notification settings - Fork 33
add operational_metrics support #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
743649c to
e4c38d7
Compare
|
@memodi please have a look at https://github.com/netobserv/flowlogs-pipeline/blob/e4c38d75c32ecc49b639fce89516a83e0bd272fc/docs/operational-metrics.md those are the new operational metrics that should help us to understand if and how FLP is working. If needed we can add more, please advise :-) @jotak FYI ^^^ |
memodi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @eranra these will be certainly helpful. Added couple of comments on naming but probably have more feedback once I actually test it.
Couple of questions:
- are these enabled by default?
- will these be pushed to prometheus?
- I believe once this task https://issues.redhat.com/browse/NETOBSERV-247 is finished, we'd be also able to grab these metrics from the FLP endpoint, correct?
Yes, as long as you enable the Prometheus encode stage. Currently, this is NOT the configuration in NOO so we will need to change that for those metrics to be available for you :-)
YES
@jotak please help with (3) --- I think that the answer is yes, but just want to be on the safe side here. |
e4c38d7 to
8485a1d
Compare
ronensc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of auto-generated documentation of the operational metrics.
8485a1d to
67e497b
Compare
67e497b to
4b3b4d3
Compare
No description provided.