Skip to content

Conversation

@eranra
Copy link
Collaborator

@eranra eranra commented Apr 7, 2022

No description provided.

@eranra eranra requested review from KalmanMeth, jotak and memodi April 7, 2022 12:08
@eranra eranra linked an issue Apr 7, 2022 that may be closed by this pull request
@eranra eranra force-pushed the 127_operational_metrics branch 3 times, most recently from 743649c to e4c38d7 Compare April 7, 2022 12:12
@eranra
Copy link
Collaborator Author

eranra commented Apr 7, 2022

@memodi please have a look at https://github.com/netobserv/flowlogs-pipeline/blob/e4c38d75c32ecc49b639fce89516a83e0bd272fc/docs/operational-metrics.md those are the new operational metrics that should help us to understand if and how FLP is working. If needed we can add more, please advise :-)

@jotak FYI ^^^

Copy link
Member

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eranra these will be certainly helpful. Added couple of comments on naming but probably have more feedback once I actually test it.

Couple of questions:

  1. are these enabled by default?
  2. will these be pushed to prometheus?
  3. I believe once this task https://issues.redhat.com/browse/NETOBSERV-247 is finished, we'd be also able to grab these metrics from the FLP endpoint, correct?

@eranra
Copy link
Collaborator Author

eranra commented Apr 10, 2022

thanks @eranra these will be certainly helpful. Added couple of comments on naming but probably have more feedback once I actually test it.

Couple of questions:

  1. are these enabled by default?

Yes, as long as you enable the Prometheus encode stage. Currently, this is NOT the configuration in NOO so we will need to change that for those metrics to be available for you :-)

  1. will these be pushed to Prometheus?

YES

  1. I believe once this task https://issues.redhat.com/browse/NETOBSERV-247 is finished, we'd be also able to grab these metrics from the FLP endpoint, correct?

@jotak please help with (3) --- I think that the answer is yes, but just want to be on the safe side here.

@eranra eranra force-pushed the 127_operational_metrics branch from e4c38d7 to 8485a1d Compare April 10, 2022 11:39
Copy link
Collaborator

@ronensc ronensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of auto-generated documentation of the operational metrics.

@eranra eranra force-pushed the 127_operational_metrics branch from 8485a1d to 67e497b Compare April 10, 2022 19:18
@eranra eranra force-pushed the 127_operational_metrics branch from 67e497b to 4b3b4d3 Compare April 14, 2022 07:44
@eranra eranra merged commit c0bf652 into netobserv:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operational Metrics

4 participants