NETOBSERV-465: Kafka metrics 2 #259
Conversation
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 61.63% 60.19% -1.45%
==========================================
Files 67 67
Lines 3915 4052 +137
==========================================
+ Hits 2413 2439 +26
- Misses 1350 1459 +109
- Partials 152 154 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkg/pipeline/ingest/ingest_kafka.go
Outdated
| flowErrors.With(prometheus.Labels{"router": "", "error": "No TimeFlowEnd found"}).Inc() | ||
| return | ||
| } else { | ||
| fmt.Println(TimeFlowEndInterface) |
There was a problem hiding this comment.
Do you really want to print to stdout for each end of flow? or is this only for debug purposes?
There was a problem hiding this comment.
Definitly not, this is a debug trace that I forgot to remove.
Thanks
pkg/test/utils.go
Outdated
| func WaitFromChannel(in chan []config.GenericMap, timeout int64) ([]config.GenericMap, error) { | ||
| duration := time.Duration(timeout) * time.Millisecond |
There was a problem hiding this comment.
Won't it be more idiomatic to change the type of timeout from int64 to time.Duration?
Then, in the invocation side, one can argue that it is more apparent what the unit of time is:
test.WaitFromChannel(ingestOutput, 2 * time.Second)There was a problem hiding this comment.
Good point thanks!
I changed it.
OlivierCazade
force-pushed
the
kafka-metrics-2
branch
from
1e7bf5a to
e4e388b
Compare
5 participants
Added more metrics to the kafka ingester and added timeout mecanics to the kafka tests.