Skip to content

Conversation

@tomchkk
Copy link
Contributor

@tomchkk tomchkk commented Mar 24, 2023

JIRA Status

Overview

  • I have performed a self review of my code
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have added sufficient logging
  • New and existing tests pass locally with my changes
  • The code modified as part of this PR has been covered with tests
  • The API spec has been modified inline with the changes in this PR

Problem statement

Add Laravel 10 support

Solution

Dependencies

n/a

Test procedures

n/a

Links

n/a

Deployment

Migrations

No

Environment variables

n/a

Deployment notes

n/a

@tomchkk tomchkk requested a review from kubatek94 March 24, 2023 15:57
@tomchkk
Copy link
Contributor Author

tomchkk commented Mar 24, 2023

@kubatek94 - I published this package in preparation for adding to the laravel-template and then, while playing around with requiring it on a new project, I realised that it's not compatible with Laravel 10 😔 so I've updated it!

@tomchkk tomchkk merged commit 0d526a5 into main Mar 24, 2023
@tomchkk tomchkk deleted the feature/add-laravel-10-support branch March 24, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants