-
Notifications
You must be signed in to change notification settings - Fork 43
use denser random graphs in distance tests #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
leotrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point I'd recommend aliasing i.e. doing something like create_graph = nx.fast_gnp_random_graph(...) at the top of everything so we're sure we caught all of the instances of 0.1 and changed them to 0.3. I'm approving anyway...
|
The tests are failing on denser graphs. |
|
Do we know which is the offending distance? |
|
|
|
My knee-jerk reaction is that This doesn't explain why upping the density caused a problem, of course. |
|
Anything that uses the Laplacian should coerce undirected tho. |
See #239.