json response: removed automatic cache disabling

[hrach]

The json output isn't something special what shouldn't be cached at all. If disabling of cache is needed, this should be handled by Nette Presenter itself.

It's probably BC Break.

[Majkl578]

👍 Disabling caching doesn't make sense.

[fprochazka]

Is there a way to override this? Or you just couldn't use the response object if you wanned it to be cached?

Maybe an option would be better than removing it completely.

[enumag]

👍 Makes sence.

[dg]

Can you change json response to JsonResponse in commit message?

[hrach]

Repushed with BC break info.

[enumag]

Maybe we should add $expiration parameter to Presenter::sendJson();? Not sure about what the default value should be though.

[Majkl578]

Why? You can configure it directly through Http\Response object.

[hrach]

I don't see the added valude, only the added complexity of another parameter. Feel free to change the expiration in the Response instance.

[enumag]

Well to achieve the original behavior I'll have to replace all of my occurences of sendJson with

$response = new JsonResponse($data);
$response->setExpiration(false);
$this->sendResponse($response);

The parameter would simplify it pretty well.

[Majkl578]

Or you can just use:

$this->getHttpResponse()->setExpiration(FALSE);
$this->sendJson(...);

[hrach]

Thanks!