VaribaleTemplate: add getParameters() method to improve back compatability #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hm, travis failed, but as far as I can tell, it's unrelated with this change. |
Member
|
Hmmm, there is not getParameters()? It extends Latte\Template. |
Contributor
Author
|
There is, but it's returning parameters of |
Member
|
Oh! Please can you fix typo in commit message: |
xificurk
force-pushed
the
variable-template-bc
branch
from
3c2fe0e to
ff323a9
Compare
Contributor
Author
|
Good catch! Fixed. |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few custom macros use something like: https://github.com/brabijan/images/blob/master/src/Brabijan/Images/Macros/Latte.php#L138