Fix warning while forwarding to Error presenter #202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forwarding to Error presenter
xificurk
force-pushed
the
fix-warning-on-forward
branch
from
e9a6aef to
d3de2a7
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
68ab1de to
1dbc728
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
be77df6 to
e1162e0
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
10a5830 to
e402814
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
56c5e11 to
5919611
Compare
Member
|
Thanks! |
dg
pushed a commit
that referenced
this pull request
Feb 19, 2019
…forwarding to Error presenter [Closes #202]
dg
pushed a commit
that referenced
this pull request
Mar 9, 2019
…forwarding to Error presenter [Closes #202]
dg
pushed a commit
that referenced
this pull request
Mar 9, 2019
…forwarding to Error presenter [Closes #202]
dg
pushed a commit
that referenced
this pull request
Mar 9, 2019
…forwarding to Error presenter [Closes #202]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application::processException()in some cases uses presenter instance to create the forwarding request to Error presenter, see https://github.com/nette/application/blob/master/src/Application/Application.php#L159The problem is that at this point we're not guaranteed that the presenter has intialized global state (namely
Presenter::$globalParamsmight be null), e.g. therun()method was not yet called. This results in pretty confusing warning:The easiest fix is to set the default value for
globalParamsto empty array.