Removing nette/reflection [WIP] #91
Conversation
src/Application/UI/Presenter.php
Outdated
There was a problem hiding this comment.
Because $this is an instance, not a type name.
There was a problem hiding this comment.
It works, ReflectionClass accepts objects.
There was a problem hiding this comment.
But ReflectionObject is semantically more correct, and also extends ReflectionClass.
There was a problem hiding this comment.
What's the difference between ReflectionClass and ReflectionObject anyway? I couldn't find anything worth mentioning in the docs.
There was a problem hiding this comment.
I think that ReflectionObject::getProperties returns real object properties and ReflectionClass::getProperties returns default properties from a class.
dg
force-pushed
the
reflection
branch
2 times, most recently
from
1c59caf to
84ebe7d
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
8e097dc to
e4eb640
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
7f051bf to
f87df33
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
9725b1d to
9869e52
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
18f376d to
3fe619f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
20a93ca to
08cbdeb
Compare
dg
force-pushed
the
master
branch
9 times, most recently
from
41da593 to
2c1ae3b
Compare
dg
force-pushed
the
master
branch
15 times, most recently
from
8f2b6ff to
83f19ce
Compare
…lection classes instead of Nette\Reflection\* (BC break!)
|
@dg What about composer.json? |
|
In next version. |
|
Why? It's not needed by this package so it should not be there, only in suggests section. If anyone was using it directly, they've been shooting themselves in the foot -- they should've had it in their composer.json. |
|
Because back compatibility |
|
I don't get it. This package doesn't need that package anymore so it should just drop the dependency entirely. Noone should ever depend on a library indirectly through another dependency because it is just not what dependency means. |
|
It is directly used in code. |
|
Even if this affects anyone its easily fixable by one line in composer.json. Its ok to put a minor BC break like that into 2.4 in my opinion. |
3 participants
No description provided.