Skip to content

Conversation

@Hajneej
Copy link
Contributor

@Hajneej Hajneej commented May 27, 2015

Selection refetch invalidates data but not references

@Hajneej
Copy link
Contributor Author

Hajneej commented May 27, 2015

Hi
I found an issue with invalidating selection. The bug is described in test. I am not exactly sure about the fix and about impact to other parts. Please review it, thanks

@Hajneej Hajneej force-pushed the bug-selection-cache branch from ba3c4dc to 61586fb Compare May 27, 2015 11:59
@dg dg force-pushed the master branch 4 times, most recently from 0fc7ac2 to 7194522 Compare June 21, 2015 16:17
@MartinMystikJonas
Copy link
Contributor

Ano progress on reviewing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use uppercased NULL, single quotes where possible, tabs, space in function () and consistent commit message.

@Hajneej Hajneej force-pushed the bug-selection-cache branch from 61586fb to f7ab4a8 Compare July 14, 2015 15:17
@Hajneej
Copy link
Contributor Author

Hajneej commented Jul 27, 2015

fixed

@dg
Copy link
Member

dg commented Jul 27, 2015

Thanks

dg added a commit that referenced this pull request Jul 27, 2015
@dg dg merged commit 4f07ab3 into nette:master Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants