Referenced cache performance

[Hajneej]

Selection: referenced cache cleared only for root selection (not in GroupedSelection), performance improvment

solves #91

[Hajneej]

ping @hrach - refactor to more clean version

[dg]

Place $this->refCache['referenced'] = []; here.

[Hajneej]

running line $this->refCache['referenced'] = []; for GroupedSelection was actually the problem that i am trying to solve. This will actually break the query.count.phpt test

[dg]

Why?

[hrach]

Sorry, my previous comment, which I deleted yesterday?, was wrong. I misread the code. The previous version was probably better :| I really sorry.

[Hajneej]

Because of the iteration in iteration. The deleting referencedCache is launched for each inner interation. This leads to increasing number of sent queries (from 3 to 5 in query.count.phpt)

[dg]

I don't see any difference between your code and this solution:

class GroupedSelection

protected function emptyResultSet(..) 
{
  parent::emptyResultSet($saveCache);
  $this->refCache['referenced'] = [];
}

Where is a difference?

[Hajneej]

Difference:

1. My solution:
   When emptyResultSet() is called on Selection, the $this->refCache['referenced'] = []; line is executed. (the default value of second parameter is true)

When emptyResultSet() is called on GroupedSelection, the $this->refCache['referenced'] = []; is not executed (the second parameter of emptyResultSet is false)

2. Your solution
   Its actually the opposite version of mine.

[Hajneej]

to @hrach no problem :) i kind of prefer the previous version too. I was actually quite thinking about the realisation of what you thought

[dg]

Oh, now I see. So what about

$old = $this->refCache['referenced'];
parent::emptyResultSet($saveCache);
$this->refCache['referenced'] = $old;

[Hajneej]

The reason of adding a parameter was that i was thinking e.g. about adding new descendant of Selection. Than this behaviour will be probably shared so i choose a parameter.

But i am completely fine with your solution too, if this is not an issue.

[dg]

shoud be FALSE