DI: edited link #448
Merged
DI: edited link #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Machy8
commented
May 23, 2016
Machy8
commented
- Link was pointing to a nonexisting page - https://api.nette.org/2.3/Nette.DI.Extensions.NetteExtension.html#_afterCompile
- Link was pointing to a nonexisting page - https://api.nette.org/2.3/Nette.DI.Extensions.NetteExtension.html#_afterCompile
Contributor
|
You have to edit code on line 162, because code on link is not same as code in documentation. |
Contributor
Author
|
Yes, you are right. I know. But I have no idea which part of the code according to the "Here is a piece of code of initialize where Nette..." is the right part. But if it doesn't matter, I can copy there the whole code (but perhaps that is not what authors wanted). |
Member
|
IMHO link should be removed, NetteExtension doesn't exist now. |
Contributor
Author
|
So, should I edit the pull request in some way? |
Member
|
Yes, you can remove link and push it again. |
dg
force-pushed
the
doc-2.4
branch
4 times, most recently
from
c04aa7c to
de4f178
Compare
Member
|
It needs rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.