Skip to content

netteForms: toggle back compatibility fix #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2019
Merged

netteForms: toggle back compatibility fix #213

merged 1 commit into from
Mar 10, 2019

Conversation

@solcik
Copy link
Contributor

@solcik solcik commented Mar 10, 2019

dg
dg reviewed Mar 10, 2019
View reviewed changes
src/assets/netteForms.js Outdated
*/
Nette.toggle = function(selector, visible, srcElement) { // eslint-disable-line no-unused-vars
if (/^\w+$/.test(selector)) { // id
if (/^\w[\w\d-_.,]*$/.test(selector)) { // id
Copy link
Member

@dg dg Mar 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it must be [\w\d_.,-]

Copy link
Contributor Author

@solcik solcik Mar 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as you suggested.

@dg
Copy link
Member

dg commented Mar 10, 2019

Thanks!

@dg dg merged commit f92f9fb into nette:master Mar 10, 2019
dg pushed a commit that referenced this pull request Mar 10, 2019
@solcik @dg
netteForms: toggle back compatibility fix (#213)
dbf9ff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dg dg dg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

netteForms: Nette.toggle back compatibility

2 participants

@solcik @dg