Fixed onError event dispatching

[enumag]

This closes #71.

[fprochazka]

tady ten by tu být neměl aby se ověřilo že se to zavolá ikdyž je tam jenom jeden onSuccess

[enumag]

ono se to nevolalo pokud error nastal v posledním onSuccess handleru - jejich celkový počet nemá vliv, tedy je jedno zda tenhle onSuccess odstraním či nikoli

[fprochazka]

Pravda :)

[enumag]

Should I refactor it to this? It has better performance because isValid is not called multiple times.

(each isValid call means going through the whole component subtree)

        if (!$this->isValid()) {
            $this->onError($this);
        } elseif ($this->onSuccess) {
            foreach ($this->onSuccess as $handler) {
                $params = Nette\Utils\Callback::toReflection($handler)->getParameters();
                $values = isset($params[1]) ? $this->getValues($params[1]->isArray()) : NULL;
                Nette\Utils\Callback::invoke($handler, $this, $values);
                if (!$this->isValid()) {
                    $this->onError($this);
                    break;
                }
            }
        }

[dg]

Can you write better commit message?

[enumag]

What's wrong with this one? I can't come up with anything better.

[vojtech-dobes]

Form::fireEvents() calls onError even with only one success handler (deducing from original issue)

[enumag]

@vojtech-dobes That's actually wrong. The onError event previously wasn't called if the error was added by last onSuccess handler (regardless how many there are in total).

[enumag]

Maybe Form::fireEvents() can call onError even after last onSuccess handler ?

[fprochazka]

@enumag

Form::fireEvents() calls onError even after last onSuccess handler

[enumag]

Commit message changed (thx @fprochazka). I've also changed the implementation to the one with better performance as mentioned above.

[vojtech-dobes]

👍

[dg]

Thank you