PHP interpreters refactoring II. #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hasXdebug() => canMeasureCodeCoverage() - getErrorOutput() => getStartupError()
dg
force-pushed
the
pull-interpret
branch
4 times, most recently
from
7cb656e to
a6433bb
Compare
Member
Author
|
|
Contributor
It is not. HHVM is provided as /usr/bin/php on Debian-based systems through /etc/alternatives. |
Member
Author
|
Ok, I'll change it |
dg
force-pushed
the
pull-interpret
branch
2 times, most recently
from
6be7370 to
f97090d
Compare
…class PhpInterpreter (BC break)
dg
force-pushed
the
pull-interpret
branch
2 times, most recently
from
16bcad9 to
c5843be
Compare
Member
|
@dg Thanks for review and refactoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.