Finder: Fix symlink handling #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
2 times, most recently
from
fc24539 to
0a94bd7
Compare
Member
|
Thanks |
dg
force-pushed
the
master
branch
5 times, most recently
from
b724dd7 to
c7ec447
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
3e4da44 to
089bddf
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
fac1545 to
cddcabd
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
7ccfad0 to
71017d2
Compare
dg
added a commit
that referenced
this pull request
Sep 19, 2023
- getType() throws an exception when the file (no longer) exists - there is a difference regarding handling of symlinks [#295]
dg
pushed a commit
that referenced
this pull request
Sep 19, 2023
Co-authored-by: Jiri Hrazdil <jiri@hrazdil.info>
dg
pushed a commit
that referenced
this pull request
Sep 19, 2023
dg
added a commit
that referenced
this pull request
Sep 19, 2023
- getType() throws an exception when the file (no longer) exists - there is a difference regarding handling of symlinks [#295]
dg
pushed a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
Finder (v2) did use
isFile()orisDir()to determine type ofSplFileInfo(link).After migration to
nette/utils, it usesSplFileInfo::getType()(link).There is a slight difference between the two approaches regarding handling of symlinks - if
SplFileInfois a symlink to a file,isFile()returnstrue(although it is not documented - see comment), whilegetType()returnslink(and thus fails=== 'file'comparison).This leads to change of behavior in nette/utils v4 when Finder only returns real files, not symlinks and there is no way to return to the previous behaviour.
Steps To Reproduce
mkdir ./test && touch ./file.txt && cd ./test && ln -s ../file.txt)Finder::findFiles('*')->in('./test')returns empty array