task for heartbleed attack #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Out of curiosity, what are the main differences from the current implementation? |
Contributor
Author
|
They look the same, it's just a cleaner implementation that I was using. |
maybe-hello-world
approved these changes
Sep 7, 2024
Contributor
maybe-hello-world
left a comment
maybe-hello-world
left a comment
There was a problem hiding this comment.
I'm not entirely sure what is meant by cleaner. The current code is not formatted (you can use Black, for example), doesn't have any types, and provides less configurability.
I don't intend to prevent you from using it though so LGTM. :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.